Phriction - move delete business logic from controlller to editor
ClosedPublic
Actions

Authored by btrahan on Nov 7 2014, 5:25 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T4029: Support policies on Phriction wiki articles

Commits

Restricted Diffusion Commit
rP622eaac9ed40: Phriction - move delete business logic from controlller to editor

Summary

Ref T4029. More cleanup and code consolidation for the long terms benefits.

Test Plan

found a document and opened up two browser tabs. Loaded delete dialog on both. Completed delete in one tab and noted document was properly deleted. Tried to complete delete in tab 2 and got an error message.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25935.Nov 7 2014, 5:25 PM

btrahan added a task: T4029: Support policies on Phriction wiki articles.

btrahan retitled this revision from to Phriction - move delete business logic from controlller to editor.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 7 2014, 5:25 PM

Harbormaster completed remote builds in B2982: Diff 25935.Nov 7 2014, 5:26 PM

epriestley accepted this revision.Nov 7 2014, 5:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 7 2014, 5:45 PM

Closed by commit rP622eaac9ed40: Phriction - move delete business logic from controlller to editor (authored by btrahan, committed by btrahan). · Explain WhyNov 7 2014, 6:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDeleteController.php

27 lines

editor/

PhrictionTransactionEditor.php

23 lines

Diff 25939

View Options

src/applications/phriction/controller/PhrictionDeleteController.php