Page MenuHomePhabricator
Differential D10809

Phriction - move delete business logic from controlller to editor
ClosedPublic
Actions

Authored by btrahan on Nov 7 2014, 5:25 PM.
Tags
None
Referenced Files
F14824329: D10809.diff
Tue, Jan 28, 5:20 PM
F14816139: D10809.id25939.diff
Mon, Jan 27, 10:39 PM
F14816138: D10809.id25935.diff
Mon, Jan 27, 10:39 PM
F14816137: D10809.id.diff
Mon, Jan 27, 10:38 PM
Unknown Object (File)
Sat, Jan 25, 1:04 PM
Unknown Object (File)
Thu, Jan 23, 6:12 PM
Unknown Object (File)
Thu, Jan 23, 6:12 PM
Unknown Object (File)
Thu, Jan 23, 6:12 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T4029: Support policies on Phriction wiki articles
Commits
Restricted Diffusion Commit
rP622eaac9ed40: Phriction - move delete business logic from controlller to editor
Summary

Ref T4029. More cleanup and code consolidation for the long terms benefits.

Test Plan

found a document and opened up two browser tabs. Loaded delete dialog on both. Completed delete in one tab and noted document was properly deleted. Tried to complete delete in tab 2 and got an error message.

Diff Detail

Repository
rP Phabricator
Branch
T4029
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2982
Build 2986: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25935.Nov 7 2014, 5:25 PM
btrahan added a task: T4029: Support policies on Phriction wiki articles.
btrahan retitled this revision from to Phriction - move delete business logic from controlller to editor.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 7 2014, 5:25 PM
Harbormaster completed remote builds in B2982: Diff 25935.Nov 7 2014, 5:26 PM
epriestley accepted this revision.Nov 7 2014, 5:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2014, 5:45 PM
Closed by commit rP622eaac9ed40: Phriction - move delete business logic from controlller to editor (authored by btrahan, committed by btrahan). · Explain WhyNov 7 2014, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
controller/
27 lines
editor/
23 lines

Diff 25935

View Options

src/applications/phriction/controller/PhrictionDeleteController.php

Loading...
View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
Phabricator · Built by Phacility