Page MenuHomePhabricator
Differential D10807

Phriction - fix bug with delete
ClosedPublic
Actions

Authored by btrahan on Nov 7 2014, 4:59 PM.
Tags
None
Referenced Files
F14357426: D10807.diff
Fri, Dec 20, 4:41 AM
F14353086: D10807.id25933.diff
Thu, Dec 19, 4:22 PM
F14353085: D10807.id25932.diff
Thu, Dec 19, 4:22 PM
F14353084: D10807.diff
Thu, Dec 19, 4:22 PM
F14352392: D10807.id.diff
Thu, Dec 19, 1:40 PM
Unknown Object (File)
Fri, Dec 13, 8:44 PM
Unknown Object (File)
Fri, Dec 6, 2:51 PM
Unknown Object (File)
Thu, Nov 28, 3:42 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Baby Tequila" token, awarded by epriestley.

Details

Reviewers
epriestley
chad
Maniphest Tasks
T6489: Unable to delete Phriction document completely
Commits
Restricted Diffusion Commit
rP677e161865a4: Phriction - fix bug with delete
Summary

Fixes T6489. In an earlier diff I forgot to update the document status itself, thinking that the content update percolated up magically. Restore this functionality so the wiki works better.

Test Plan

deleted a document and observed that i did not get the option to delete it again and it disappeared from document index

Diff Detail

Repository
rP Phabricator
Branch
T6489
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2980
Build 2984: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25932.Nov 7 2014, 4:59 PM
btrahan added a task: T6489: Unable to delete Phriction document completely.
btrahan retitled this revision from to Phriction - fix bug with delete.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 7 2014, 4:59 PM
Harbormaster completed remote builds in B2980: Diff 25932.Nov 7 2014, 4:59 PM
chad accepted this revision.Nov 7 2014, 5:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2014, 5:05 PM
Closed by commit rP677e161865a4: Phriction - fix bug with delete (authored by btrahan, committed by btrahan). · Explain WhyNov 7 2014, 5:08 PM
This revision was automatically updated to reflect the committed changes.
epriestley awarded a token.Nov 7 2014, 5:45 PM

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
editor/
3 lines

Diff 25932

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
Phabricator · Built by Phacility