Differential D10792

Phriction - kill the old PhrictionDocumentEditor
ClosedPublic
Actions

Authored by btrahan on Nov 5 2014, 10:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 7, 6:12 AM

	Unknown Object (File)
	Tue, Jan 7, 6:12 AM

	Unknown Object (File)
	Tue, Dec 24, 10:47 AM

	Unknown Object (File)
	Sat, Dec 21, 4:34 AM

	Unknown Object (File)
	Fri, Dec 20, 9:48 AM

	Unknown Object (File)
	Thu, Dec 19, 4:21 PM

	Unknown Object (File)
	Thu, Dec 19, 4:21 PM

	Unknown Object (File)
	Thu, Dec 19, 4:21 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4029: Support policies on Phriction wiki articles

Commits

Restricted Diffusion Commit
rP9f8dde9cf603: Phriction - kill the old PhrictionDocumentEditor

Summary

Ref T4029. Long live PhrictionTransactionEditor...! this means that all existing functionality runs 100% through the modern transactions + editor framework. this diff does a few things in sum

kills the old editor
moves conduit-based edits to new editor
moves stubbing out documents to new editor
deletes moving of wiki docs for projects functionality... (T4021#59511 is a better bigger battle plan here.)

Test Plan

edited a phriction document via conduit and it worked. created a new phriction document /that/was/deep/ and verified ancestral documents were properly stubbed out. changed a project name and noted no wiki page moves.

Diff Detail

Repository

Branch

T4029

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2957
Build 2961: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25896.Nov 5 2014, 10:02 PM

btrahan added a task: T4029: Support policies on Phriction wiki articles.

btrahan retitled this revision from to Phriction - kill the old PhrictionDocumentEditor.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 5 2014, 10:02 PM

Harbormaster completed remote builds in B2956: Diff 25896.Nov 5 2014, 10:03 PM

btrahan added inline comments.Nov 5 2014, 10:03 PM

src/applications/phriction/query/PhrictionDocumentQuery.php
211 ↗	(On Diff #25896)	whoops, will purge

remove stray phlog

Harbormaster completed remote builds in B2957: Diff 25897.Nov 5 2014, 10:05 PM

This puts project pages in a slightly more awkward spot, but that seems reasonable until we can dig them out of the automagic mess.

This revision is now accepted and ready to land.Nov 6 2014, 8:25 PM

Closed by commit rP9f8dde9cf603: Phriction - kill the old PhrictionDocumentEditor (authored by btrahan, committed by btrahan). · Explain WhyNov 6 2014, 10:01 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D11134: Remove an unused class.Jan 1 2015, 11:39 PM

joshuaspence mentioned this in rPc98aab6a21ea: Remove an unused class.Jan 2 2015, 12:33 AM

joshuaspence mentioned this in D13116: Remove unused PhrictionActionConstants class.Jun 2 2015, 2:40 PM

joshuaspence mentioned this in rPc26ea062d1fb: Remove unused PhrictionActionConstants class.Jun 3 2015, 10:23 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

phriction/

conduit/

PhrictionEditConduitAPIMethod.php

21 lines

editor/

PhrictionDocumentEditor.php

PhrictionTransactionEditor.php

52 lines

storage/

PhrictionTransaction.php

29 lines

project/

editor/

PhabricatorProjectTransactionEditor.php

36 lines

Diff 25897

src/__phutil_library_map__.php

Loading...

src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php

Loading...

src/applications/phriction/editor/PhrictionDocumentEditor.php

Loading...

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...

src/applications/phriction/storage/PhrictionTransaction.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...