Paths

Table of Contentst

Differential D10780

Allow Javelin initBehavior to source alternative library behaviors
ClosedPublic
Actions

Authored by ChristopherHJohnson on Nov 4 2014, 12:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 10:38 PM

	Unknown Object (File)
	Sun, Jan 26, 7:31 AM

	Unknown Object (File)
	Thu, Jan 23, 6:04 PM

	Unknown Object (File)
	Thu, Jan 23, 6:04 PM

	Unknown Object (File)
	Thu, Jan 23, 6:04 PM

	Unknown Object (File)
	Thu, Jan 23, 6:04 PM

	Unknown Object (File)
	Thu, Jan 23, 6:04 PM

	Unknown Object (File)
	Tue, Jan 21, 3:42 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library.

Commits

Restricted Diffusion Commit
rP5b490e98d8a3: Allow Javelin initBehavior to source alternative library behaviors

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Ref T6467. Opens up initBehavior for non-phabricator sourced behaviors.

Test Plan

Confirmed no impact on unset (default 'phabricator' source name) calls to initBehavior

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2942
Build 2946: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

ChristopherHJohnson updated this revision to Diff 25871.Nov 4 2014, 12:35 PM

ChristopherHJohnson retitled this revision from to Allow Javelin initBehavior to source alternative library behaviors.

ChristopherHJohnson updated this object.

ChristopherHJohnson edited the test plan for this revision. (Show Details)

ChristopherHJohnson added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 4 2014, 12:35 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B2940: Diff 25871.Nov 4 2014, 12:36 PM

ChristopherHJohnson added a task: T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library..Nov 4 2014, 12:38 PM

aklapper added a subscriber: aklapper.Nov 4 2014, 1:50 PM

epriestley requested changes to this revision.Nov 4 2014, 1:56 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/infrastructure/javelin/Javelin.php
6–8	By convention, indent two spaces.
8	In this codebase, prefer `$source_name = 'phabricator'` to establish a default scalar parameter value (i.e., an explicit default). This: is clearer for humans when browsing the method signature; is accessible to documentation generators and static analysis; does not generate errors like this one: [2014-11-04 05:54:04] ERROR 2: Missing argument 3 for Javelin::initBehavior(), called in /INSECURE/devtools/phabricator/src/view/page/menu/PhabricatorMainMenuSearchView.php on line 49 and defined at [/INSECURE/devtools/phabricator/src/infrastructure/javelin/Javelin.php:8]"

This revision now requires changes to proceed.Nov 4 2014, 1:56 PM

epriestley updated this object.Nov 4 2014, 1:57 PM

epriestley edited edge metadata.

establishs a default scalar parameter value for source_name

Harbormaster completed remote builds in B2942: Diff 25874.Nov 4 2014, 2:07 PM

corrects indentation to two spaces lines 6-8

Harbormaster completed remote builds in B2943: Diff 25875.Nov 4 2014, 2:09 PM

epriestley accepted this revision.Nov 4 2014, 2:46 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2014, 2:46 PM

Closed by commit rP5b490e98d8a3: Allow Javelin initBehavior to source alternative library behaviors (authored by ChristopherHJohnson, committed by epriestley). · Explain WhyNov 4 2014, 2:47 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library..Nov 4 2014, 2:48 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

celerity/

CelerityStaticResourceResponse.php

2 lines

infrastructure/

javelin/

9 lines

Diff 25874

src/applications/celerity/CelerityStaticResourceResponse.php

Loading...

src/infrastructure/javelin/Javelin.php

Loading...