Page MenuHomePhabricator
Differential D10774

Include object url in object selector selection
ClosedPublic
Actions

Authored by chad on Nov 2 2014, 8:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 5:17 PM
Unknown Object (File)
Thu, Jan 23, 6:03 PM
Unknown Object (File)
Thu, Jan 23, 6:02 PM
Unknown Object (File)
Thu, Jan 23, 6:02 PM
Unknown Object (File)
Thu, Jan 23, 6:02 PM
Unknown Object (File)
Mon, Dec 30, 3:12 AM
Unknown Object (File)
Dec 25 2024, 8:05 AM
Unknown Object (File)
Dec 19 2024, 1:35 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6452: Clicable task titles in "Edit Blocking Tasks" dialog should point to the respective tasks
Commits
Restricted Diffusion Commit
rPd1d3b3221316: Include object url in object selector selection
Summary

Fixes T6452, provides actual href instead of just #

Test Plan

Control click and open link in new window, is correct task. Click and see item added to selection list.

Diff Detail

Repository
rP Phabricator
Branch
obj-sel
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2932
Build 2936: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25859.Nov 2 2014, 8:48 PM
chad retitled this revision from to Include object url in object selector selection.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T6452: Clicable task titles in "Edit Blocking Tasks" dialog should point to the respective tasks.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 2 2014, 8:48 PM
Harbormaster completed remote builds in B2932: Diff 25859.Nov 2 2014, 8:49 PM
epriestley accepted this revision.Nov 3 2014, 3:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2014, 3:31 PM
epriestley mentioned this in T6452: Clicable task titles in "Edit Blocking Tasks" dialog should point to the respective tasks.Nov 3 2014, 3:32 PM
Closed by commit rPd1d3b3221316: Include object url in object selector selection (authored by chad, committed by chad). · Explain WhyNov 3 2014, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
webroot/
rsrc/
js/
core/
2 lines

Diff 25859

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/behavior-object-selector.js

Loading...
Phabricator · Built by Phacility