Page MenuHomePhabricator

Clicable task titles in "Edit Blocking Tasks" dialog should point to the respective tasks
Closed, ResolvedPublic

Description

  1. Reach a task, click "Edit blocking tasks"
  2. Search something which gives at least one result
  3. Ctrl-click (or equivalent) a blue link, i.e. a task title, to open it in new tab

I. Observed: the current task is opened instead.
II. Expected: the task corresponding to the label of the link is opened.

In the current design, a clickable string in blue just looks like a normal link, hence the logical expectation is to open a new window with the page of the task clicked. "Select" appears with its own button. The icon in the left does point to the task mentioned in the same row.

Not a big deal, but it is unclear whether this is a mistake or intended design.

Original report: https://phabricator.wikimedia.org/T1027

Event Timeline

qgil raised the priority of this task from to Needs Triage.
qgil updated the task description. (Show Details)
qgil added projects: Maniphest, Design.
qgil added a subscriber: qgil.

The intention is to click the to pull up the other page.

chad triaged this task as Low priority.Nov 2 2014, 10:24 PM
chad removed a project: Design.

It would probably be clearer to remove the icon and just link the task title normally. I wrote this element a very very long time ago, and the approach is unusual in the modern UI.

Heh, am I the only one who like the current behaviour then? It will trip people up on the change.

Oh, I actually had the history wrong on this one. Here's what actually happened:

  • Originally, it was the way this task describes (the link is a link).
  • In D1962, the title was made to act like the "Select" button and a small "external" link was added. This was a feature request from @cpiro.
  • In D7661, there was a minor CSS update.

I'm pretty ambivalent about the behavior. I personally never click task titles, and also never click the arrow link. I'd tend to pick the original behavior in a vacuum (and evidently did), but I'm also fine with retaining this as is and there seems to be support for it from people who care about it more than I do (you, @cpiro).

If you're happy with it as-is, just WONTFIX this?

Oh, or just land D10774 and we'll fix the control-click but leave the behavior otherwise unchanged.

Yeah I find the control-click an improvement.

If we're going to alter behaviour, I'd rather do that when we revamp the entire object selector.