Differential D10762

Add addLinkSection to MailBody to properly format URIs
ClosedPublic
Actions

Authored by chad on Oct 30 2014, 5:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 8:51 AM

	Unknown Object (File)
	Mon, Dec 9, 5:12 AM

	Unknown Object (File)
	Sun, Dec 1, 3:51 AM

	Unknown Object (File)
	Oct 31 2024, 7:27 AM

	Unknown Object (File)
	Oct 31 2024, 7:26 AM

	Unknown Object (File)
	Oct 31 2024, 7:26 AM

	Unknown Object (File)
	Oct 31 2024, 7:12 AM

	Unknown Object (File)
	Oct 18 2024, 9:19 PM

Subscribers

Tokens

"Like" token, awarded by hashar.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T6343: Phabricator HTML emails have unclickable URLs in Thunderbird

Commits

Restricted Diffusion Commit
rP1ac84c1b59de: Add addLinkSection to MailBody to properly format URIs

Summary

Fixes T6343. Grepped for all callsites and added addLinkSection where needed.

Test Plan

Tested Differential, Maniphest, Conpherence, Ponder and Macro. Inspect HTML mail for anchor tags. Inspect text mails for non-disruption.

Diff Detail

Repository

Branch

mail-html

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 2912
Build 2916: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	testMercurialParser
	0 ms	testBodyRender
	0 ms	testBodyRenderNoHerald
	0 ms	testBodyRenderNoReply
	0 ms	testGitParser
		View Full Test Results (1 Failed · 9 Passed)

Event Timeline

chad updated this revision to Diff 25830.Oct 30 2014, 5:33 PM

chad retitled this revision from to Add addLinkSection to MailBody to properly format URIs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T6343: Phabricator HTML emails have unclickable URLs in Thunderbird.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 30 2014, 5:33 PM

Harbormaster completed remote builds in B2912: Diff 25830.Oct 30 2014, 5:34 PM

chad added inline comments.Oct 30 2014, 5:39 PM

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
89	should I wrap this in another div?

• hashar mentioned this in T6343: Phabricator HTML emails have unclickable URLs in Thunderbird.Oct 30 2014, 5:40 PM

Nice!

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
89	idk... want to give something like this a whirl? https://litmus.com/email-testing theoretically each and every html email client may render it differently. I also feel fine just letting users report rendering issues as they come up.
107–109	this site will need updating too

This revision is now accepted and ready to land.Oct 30 2014, 5:50 PM

Looks good, although it won't fix inline links (in comments and such)

Tried Litmus, things looked good. It might be worth signing up.

Closed by commit rP1ac84c1b59de: Add addLinkSection to MailBody to properly format URIs (authored by chad, committed by chad). · Explain WhyOct 30 2014, 10:24 PM

This revision was automatically updated to reflect the committed changes.

• hashar awarded a token.Nov 6 2014, 4:41 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

2 lines

conpherence/

editor/

ConpherenceEditor.php

2 lines

differential/

customfield/

DifferentialChangesSinceLastUpdateField.php

2 lines

editor/

DifferentialTransactionEditor.php

4 lines

fund/

editor/

FundInitiativeEditor.php

2 lines

legalpad/

editor/

LegalpadDocumentEditor.php

2 lines

macro/

editor/

PhabricatorMacroEditor.php

2 lines

maniphest/

editor/

ManiphestTransactionEditor.php

2 lines

metamta/

view/

PhabricatorMetaMTAMailBody.php

6 lines

PhabricatorMetaMTAMailSection.php

1 line

paste/

editor/

PhabricatorPasteEditor.php

2 lines

pholio/

editor/

PholioMockEditor.php

2 lines

phortune/

editor/

PhortuneCartEditor.php

2 lines

phriction/

editor/

PhrictionTransactionEditor.php

2 lines

ponder/

editor/

PonderAnswerEditor.php

2 lines

PonderQuestionEditor.php

2 lines

repository/

worker/

PhabricatorRepositoryPushMailWorker.php

2 lines

Diff 25830

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...

src/applications/differential/customfield/DifferentialChangesSinceLastUpdateField.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/fund/editor/FundInitiativeEditor.php

Loading...

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...

src/applications/macro/editor/PhabricatorMacroEditor.php

Loading...

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Loading...

src/applications/metamta/view/PhabricatorMetaMTAMailSection.php

Loading...

src/applications/paste/editor/PhabricatorPasteEditor.php

Loading...

src/applications/pholio/editor/PholioMockEditor.php

Loading...

src/applications/phortune/editor/PhortuneCartEditor.php

Loading...

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...

src/applications/ponder/editor/PonderAnswerEditor.php

Loading...

src/applications/ponder/editor/PonderQuestionEditor.php

Loading...

src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php

Loading...