Page MenuHomePhabricator

Diffusion - upgrade exception error message to include hint to config option
ClosedPublic

Authored by btrahan on Oct 29 2014, 4:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 6:36 PM
Unknown Object (File)
Thu, Dec 19, 6:29 PM
Unknown Object (File)
Thu, Dec 12, 12:29 PM
Unknown Object (File)
Thu, Dec 12, 2:07 AM
Unknown Object (File)
Thu, Dec 5, 8:50 PM
Unknown Object (File)
Thu, Dec 5, 10:45 AM
Unknown Object (File)
Thu, Dec 5, 8:03 AM
Unknown Object (File)
Thu, Nov 28, 2:37 AM
Subscribers

Details

Summary

Fixes T6419. Also, there was a question on T6419 about whether this was in a try catch block and it is... Its not clear to me what happens in the "timeout" case though?

Test Plan

looks nice

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Diffusion - upgrade exception error message to include hint to config option.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
62–66

ye old try and catch around this code

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
64–65

Maybe we should just remove this phlog() -- it's obvious from the mail what happened, and some users tend to find it confusing when we log expected/recovered exceptions (T6406 is similar -- the error seems scary but is extremely minor).

Either that, or add something like phlog_handled_exception() and have it print some generic "A minor error occurred / not a big deal / we are continuing normally / no cause for alarm" thing. But I think there's almost no value in logging this at all.

Another high-effort alternative would be to add a verbose flag to Workers. Currently, daemons have a verbose mode which controls whether $this->log() goes anywhere. Workers have a $this->log(), but it's always active.

We could give workers a verbose flag, have them inherit it from the daemon when run from the taskmaster, and set it on a case-by-case basis in other contexts, then call $this->log('%s', $ex->getMessage()) instead of phlog().

But just removing this line seems clean and way easier.

This revision is now accepted and ready to land.Oct 29 2014, 4:26 PM
btrahan edited edge metadata.

remove the phlog...!

This revision was automatically updated to reflect the committed changes.