Page MenuHomePhabricator
Create Task
Maniphest T6419

Error for `metamta.diffusion.byte-limit` does not point at config option
Closed, ResolvedPublic
Actions

Description

Via IRC:

denivorium: I can't seem to find the config option to control 'patch size', can someone point me in the right direction?
denivorium: the relevant error message is "EXCEPTION: (Exception) Patch size of 5 MB exceeds configured byte size limit of 1 MB. ...

This should point to the name of the config option (metamta.diffusion.byte-limit).

Revisions and Commits

rP Phabricator
D10755rPdd49096a857b Diffusion - upgrade exception error message to include hint to config option

Event Timeline

epriestley created this task.Oct 29 2014, 1:57 PM
epriestley raised the priority of this task from to Wishlist.
epriestley updated the task description. (Show Details)
epriestley added a project: Documentation.
epriestley added a subscriber: epriestley.
epriestley added a subscriber: btrahan.Oct 29 2014, 2:35 PM

+ @btrahan

Maybe this is more complicated than I think, the same user made a comment here:

https://github.com/phacility/phabricator/issues/743#issuecomment-60933302

...suggesting that this setting being too low blocked a repository from importing. The new code may not be handling this exception correctly.

If metamta.diffusion.byte-limit is set low, the Herald step should still work. I'd guess we might have dropped some try/catch code around patch construction when swapping to ApplicationTransactions. However, I haven't tried to repro this.

btrahan claimed this task.Oct 29 2014, 3:13 PM

I'll take a look.

btrahan added a revision: D10755: Diffusion - upgrade exception error message to include hint to config option.Oct 29 2014, 4:13 PM
btrahan closed this task as Resolved.Oct 29 2014, 4:28 PM
btrahan added a commit: rPdd49096a857b: Diffusion - upgrade exception error message to include hint to config option.

Closed by commit rPdd49096a857b.

Phabricator · Built by Phacility