Differential D10749

MetaMTA - make test mail implementation support message id headers by default
ClosedPublic
Actions

Authored by btrahan on Oct 27 2014, 7:53 PM.

Tags

None

Referenced Files

	F13295614: D10749.diff
	Thu, Jun 6, 5:48 AM

	F13251655: D10749.diff
	Sat, May 25, 12:17 AM

	F13225786: D10749.id25801.diff
	Sun, May 19, 5:23 PM

	F13203666: D10749.diff
	Tue, May 14, 11:58 PM

	F13186154: D10749.diff
	Sat, May 11, 3:27 AM

	Unknown Object (File)
	May 7 2024, 6:14 AM

	Unknown Object (File)
	May 3 2024, 3:54 AM

	Unknown Object (File)
	May 3 2024, 2:07 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T6372: Undefined index: supportsMessageIDHeader when running with PhabricatorMailImplementationTestAdapter

Commits

Restricted Diffusion Commit
rPcd811232f3b2: MetaMTA - make test mail implementation support message id headers by default

Summary

Fixes T6372. Apparently ye olde error logs get some crazy spam action as is... Looking around at call sites, we do not specify $config (which could specify the supportage of message id header) so it seems correct to default this to something. I went with "true" as the spot we use this seems like pretty easy stuff that will always work.

Test Plan

lots of thinking

Diff Detail

Repository

Branch

T6372

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2892
Build 2896: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25799.Oct 27 2014, 7:53 PM

btrahan added a task: T6372: Undefined index: supportsMessageIDHeader when running with PhabricatorMailImplementationTestAdapter.

btrahan retitled this revision from to MetaMTA - make test mail implementation support message id headers by default.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 27 2014, 7:53 PM

Harbormaster completed remote builds in B2892: Diff 25799.Oct 27 2014, 7:54 PM

This looks like the correct fix to me.

This revision is now accepted and ready to land.Oct 27 2014, 8:06 PM

Closed by commit rPcd811232f3b2: MetaMTA - make test mail implementation support message id headers by default (authored by btrahan, committed by btrahan). · Explain WhyOct 27 2014, 8:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

adapter/

PhabricatorMailImplementationTestAdapter.php

2 lines

Diff 25799

src/applications/metamta/adapter/PhabricatorMailImplementationTestAdapter.php

Loading...