Page MenuHomePhabricator
Differential D10743

Remove history support for console prompts on Windows
ClosedPublic
Actions

Authored by richardvanvelzen on Oct 23 2014, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 9:23 AM
Unknown Object (File)
Sun, Dec 15, 1:27 PM
Unknown Object (File)
Sun, Dec 15, 1:25 PM
Unknown Object (File)
Nov 27 2024, 9:36 PM
Unknown Object (File)
Nov 19 2024, 10:16 AM
Unknown Object (File)
Nov 14 2024, 7:45 AM
Unknown Object (File)
Nov 9 2024, 4:11 PM
Unknown Object (File)
Nov 9 2024, 1:47 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6348: Windows 7: arc diff --nolint --nounit not working
Commits
rPHU43a0b6d17bb0: Remove history support for console prompts on Windows
Summary

Fixes T6348.

Test Plan

Run arc diff --nolint --nounit and see the expected prompt, instead of just one word.

Diff Detail

Repository
rPHU libphutil
Branch
T6348
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2886
Build 2890: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

richardvanvelzen updated this revision to Diff 25788.Oct 23 2014, 7:59 PM
richardvanvelzen added a task: T6348: Windows 7: arc diff --nolint --nounit not working.
richardvanvelzen retitled this revision from to Remove history support for console prompts on Windows.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 23 2014, 7:59 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
richardvanvelzen updated this revision to Diff 25789.Oct 23 2014, 7:59 PM
richardvanvelzen edited edge metadata.

Now with lint and unit tests running

Harbormaster completed remote builds in B2885: Diff 25788.Oct 23 2014, 7:59 PM
Harbormaster completed remote builds in B2886: Diff 25789.
epriestley accepted this revision.Oct 23 2014, 8:00 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 23 2014, 8:00 PM
Closed by commit rPHU43a0b6d17bb0: Remove history support for console prompts on Windows (authored by richardvanvelzen, committed by epriestley). · Explain WhyOct 23 2014, 8:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
console/
6 lines

Diff 25789

View Options

src/console/format.php

Loading...
Phabricator · Built by Phacility