Page MenuHomePhabricator

Diffusion - maybe fix import spam bug
ClosedPublic

Authored by btrahan on Oct 20 2014, 10:31 PM.
Tags
None
Referenced Files
F13135323: D10729.diff
Thu, May 2, 8:11 AM
Unknown Object (File)
Mon, Apr 29, 4:02 PM
Unknown Object (File)
Wed, Apr 24, 11:52 PM
Unknown Object (File)
Wed, Apr 24, 7:53 AM
Unknown Object (File)
Thu, Apr 11, 8:08 AM
Unknown Object (File)
Mar 28 2024, 1:25 AM
Unknown Object (File)
Mar 25 2024, 7:10 PM
Unknown Object (File)
Mar 25 2024, 1:48 PM
Subscribers

Details

Summary

Ref T6350. I just set up a repository to import secure.phabricator.com/P and saw an error in my error logs about this, creating a fatal around when we publish feed stories. this is late enough in the editor code path I could see it firing again and again and again...

Test Plan

the first phabricator commit ever only had one duplicated transaction before i applied this patch. its yet to do it again. otherwise, ask some users with the issue to deploy it and see if it fixes things for them too.

Diff Detail

Repository
rP Phabricator
Branch
importbug
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2867
Build 2871: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Diffusion - maybe fix import spam bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
chad edited edge metadata.

Do it live

This revision is now accepted and ready to land.Oct 20 2014, 10:33 PM
This revision was automatically updated to reflect the committed changes.