Page MenuHomePhabricator
Differential D10725

Pholio - upgrade herald effects to use transactions
ClosedPublic
Actions

Authored by btrahan on Oct 17 2014, 8:44 PM.
Tags
None
Referenced Files
F14762325: D10725.diff
Thu, Jan 23, 5:41 AM
Unknown Object (File)
Tue, Jan 21, 11:03 AM
Unknown Object (File)
Sat, Jan 18, 11:26 PM
Unknown Object (File)
Fri, Jan 17, 2:21 AM
Unknown Object (File)
Wed, Jan 15, 2:09 AM
Unknown Object (File)
Tue, Jan 7, 10:23 PM
Unknown Object (File)
Sun, Jan 5, 7:45 PM
Unknown Object (File)
Sat, Dec 28, 3:13 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4484: Show Herald effects on objects in object transaction logs
Commits
Restricted Diffusion Commit
rP7a163ca654e5: Pholio - upgrade herald effects to use transactions
Summary

Ref T4484

Test Plan

Made a mock. Made a herald rule to subscribe a user if mock had a string in title. Edited mock to have said string. Observed user subscribed correctly.

Diff Detail

Repository
rP Phabricator
Branch
T4484
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2863
Build 2867: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25750.Oct 17 2014, 8:44 PM
btrahan added a task: T4484: Show Herald effects on objects in object transaction logs.
btrahan retitled this revision from to Pholio - upgrade herald effects to use transactions.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 17 2014, 8:44 PM
Harbormaster completed remote builds in B2863: Diff 25750.Oct 17 2014, 8:45 PM
epriestley accepted this revision.Oct 17 2014, 8:49 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 17 2014, 8:49 PM
Closed by commit rP7a163ca654e5: Pholio - upgrade herald effects to use transactions (authored by btrahan, committed by btrahan). · Explain WhyOct 17 2014, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
pholio/
editor/
13 lines

Diff 25750

View Options

src/applications/pholio/editor/PholioMockEditor.php

Loading...
Phabricator · Built by Phacility