we don't want to mention these phids... when expanding transactions, build the unmnentionable map and make it so. slightly hairy due to how the editor framework works, but overall i think this is the right place to put these hooks. Fixes T6331.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6331: Closing a revision via a commit generates superfluous "mention" in Task
- Commits
- Restricted Diffusion Commit
rPd9dd098e405b: Audit - fix erroneous mentions of tasks, etc via commit message
made a commit with a commit message that had fixes, refs, depends on, and auditors and saw no erroneous mentions
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T6331
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2858 Build 2862: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Yeah, this is a little hairy but seems reasonable.
| src/applications/audit/editor/PhabricatorAuditEditor.php | ||
|---|---|---|
| 501–520 | You could possibly simplify/future-proof this by using ObjectQuery (which should be able to look up "Dxxx" and "Txxx") instead of TaskQuery + RevisionQuery. | |
Comment Actions
simplify with an object query
(re-tested by running re-parse. saw the "commit" transaction get recorded again and still no erroneous mentions.)