I found this bug when using gslint. I wanted to disable the to long line rule and realised it was not working to disable a rulle using severity configuration. This diff should fix it.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Required Signatures
L28 Phacility Individual Contributor License Agreement
Create a repository with a js file and create an .arclint
{
"linters": {
"sample": {
"type": "gjslint",
"include": "(\\.js$)",
"severity": {
"E:0110": "disabled"
}
}
}
}
Now add a long javascript file with a long line. Without the arc lint it should give an error, with it no error message should be shown.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- closure_linter
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 2813 Build 2817: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 0 ms | testPHPCSLint | |
| 0 ms | testPHPLint | |
| 0 ms | testClosureLinter | |
| 0 ms | testFixLetterCase | |
| 0 ms | testJSHintLinter | |
| View Full Test Results (2 Failed · 13 Passed · 12 Skipped) |