Differential D10636

Allow adding Auditors with the singular noun.
ClosedPublic
Actions

Authored by SiebelsTim on Oct 6 2014, 12:50 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP00136f05dd6d: Allow adding Auditors with the singular noun.

Summary

Currently adding auditors in commit message only works with the plural. Make "Auditor: bla" work.

Test Plan

Unit tests. I don't know if I am supposed to add a test.

Diff Detail

Repository

rP Phabricator

Branch

herald-audit-singular

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2747
Build 2751: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

SiebelsTim updated this revision to Diff 25544.Oct 6 2014, 12:50 PM

SiebelsTim retitled this revision from to Allow adding Auditors with the singular noun..

SiebelsTim updated this object.

SiebelsTim edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 6 2014, 12:50 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2747: Diff 25544.Oct 6 2014, 12:51 PM

joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 11:59 PM

epriestley accepted this revision.May 17 2015, 2:18 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.May 17 2015, 2:18 PM

Closed by commit rP00136f05dd6d: Allow adding Auditors with the singular noun. (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2015, 2:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

PhabricatorRepositoryCommitHeraldWorker.php

2 lines

Diff 25544

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Allow adding Auditors with the singular noun.ClosedPublicActions