Page MenuHomePhabricator

Support AUTO_INCREMENT in `bin/storage adjust`
ClosedPublic

Authored by epriestley on Sep 29 2014, 7:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:58 PM
Unknown Object (File)
Sun, Apr 7, 11:57 PM
Unknown Object (File)
Thu, Apr 4, 1:20 PM
Unknown Object (File)
Thu, Apr 4, 6:22 AM
Unknown Object (File)
Wed, Mar 27, 5:38 PM
Unknown Object (File)
Mon, Mar 25, 6:55 PM
Unknown Object (File)
Mon, Mar 25, 6:55 PM
Unknown Object (File)
Mon, Mar 25, 6:55 PM
Subscribers

Details

Summary

Ref T1191. When changing the column type of an AUTO_INCREMENT column, we currently may lose the autoincrement attribute.

Instead, support it. This is a bit messy because AUTO_INCREMENT columns interact with PRIMARY KEY columns (tables may only have one AUTO_INCREMENT column, and it must be a primary key). We need to migrate in more phases to avoid this issue.

Introduce new auto and auto64 types to represent autoincrement IDs.

Test Plan
  • Saw autoincrement show up correctly in web UI.
  • Fixed an autoincrement issue on the XHProf storage table with bin/storage adjust safely.

Diff Detail

Repository
rP Phabricator
Branch
utfx28
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2697
Build 2701: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Support AUTO_INCREMENT in `bin/storage adjust`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 5:08 PM
This revision was automatically updated to reflect the committed changes.