Page MenuHomePhabricator

Support AUTO_INCREMENT in `bin/storage adjust`
ClosedPublic

Authored by epriestley on Sep 29 2014, 7:17 PM.
Tags
None
Referenced Files
F18048093: D10607.id.diff
Sun, Aug 3, 1:20 PM
F17817722: D10607.id.diff
Jul 25 2025, 11:47 PM
F17796786: D10607.id25477.diff
Jul 25 2025, 1:17 AM
F17770686: D10607.id25449.diff
Jul 23 2025, 9:51 AM
F17770183: D10607.id25477.diff
Jul 23 2025, 9:20 AM
F17770140: D10607.id25477.diff
Jul 23 2025, 9:18 AM
F17748720: D10607.diff
Jul 22 2025, 12:22 AM
F17657615: D10607.id.diff
Jul 12 2025, 12:26 PM
Subscribers

Details

Summary

Ref T1191. When changing the column type of an AUTO_INCREMENT column, we currently may lose the autoincrement attribute.

Instead, support it. This is a bit messy because AUTO_INCREMENT columns interact with PRIMARY KEY columns (tables may only have one AUTO_INCREMENT column, and it must be a primary key). We need to migrate in more phases to avoid this issue.

Introduce new auto and auto64 types to represent autoincrement IDs.

Test Plan
  • Saw autoincrement show up correctly in web UI.
  • Fixed an autoincrement issue on the XHProf storage table with bin/storage adjust safely.

Diff Detail

Repository
rP Phabricator
Branch
utfx28
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2697
Build 2701: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Support AUTO_INCREMENT in `bin/storage adjust`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 5:08 PM
This revision was automatically updated to reflect the committed changes.