Page MenuHomePhabricator
Differential D10597

Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter`
ClosedPublic
Actions

Authored by joshuaspence on Sep 28 2014, 12:44 PM.
Tags
None
Referenced Files
F14045281: D10597.diff
Wed, Nov 13, 2:34 AM
F14042594: D10597.diff
Tue, Nov 12, 4:38 AM
F14040389: D10597.diff
Mon, Nov 11, 9:46 AM
F14029818: D10597.id25574.diff
Fri, Nov 8, 9:36 PM
F14015481: D10597.diff
Sun, Nov 3, 7:33 PM
F14003614: D10597.diff
Sat, Oct 26, 8:23 AM
F13974813: D10597.diff
Fri, Oct 18, 7:29 AM
F13971556: D10597.id.diff
Thu, Oct 17, 1:57 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCe54725ec8918: Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter`
Summary

Adds an ArcanistXHPASTLinter::LINT_CONSTRUCTOR_PARENTHESES rule which ensures that (possibly empty) parentheses are used when calling a constructor.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2686
Build 2690: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25433.Sep 28 2014, 12:44 PM
joshuaspence retitled this revision from to Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 28 2014, 12:44 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2686: Diff 25433.Sep 28 2014, 12:45 PM
epriestley accepted this revision.Sep 28 2014, 12:53 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2014, 12:53 PM
joshuaspence updated this object.Oct 7 2014, 12:58 PM
joshuaspence edited edge metadata.
Closed by commit rARCe54725ec8918: Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter` (authored by joshuaspence, committed by joshuaspence).Oct 7 2014, 1:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
23 lines
__tests__/
xhpast/
12 lines

Diff 25433

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/constructor-parentheses.lint-test

Loading...
Phabricator · Built by Phacility