Differential D10595

Add `bin/storage adjust`, for adjusting schemata
ClosedPublic
Actions

Authored by epriestley on Sep 28 2014, 12:07 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character

Commits

Restricted Diffusion Commit
rPf7ee2c7467c6: Add `bin/storage adjust`, for adjusting schemata

Summary

Ref T1191. Adds a new workflow which can apply schema adjustments.

For now, it only performs database and table collation/charset adjustments. I believe these are extremely safe/minor, because they only affect the default values for newly created columns.

Test Plan

Ran migration on various database states, database/table changes went through cleanly.

Diff Detail

Repository

rP Phabricator

Branch

utfx22

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php:110	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 2684
Build 2688: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25431.Sep 28 2014, 12:07 PM

epriestley retitled this revision from to Add `bin/storage adjust`, for adjusting schemata.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T1191: Comments are truncated at first non-base-plane character.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 28 2014, 12:07 PM

Harbormaster completed remote builds in B2684: Diff 25431.Sep 28 2014, 12:08 PM

btrahan accepted this revision.Sep 30 2014, 4:58 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Sep 30 2014, 4:58 PM

Closed by commit rPf7ee2c7467c6: Add `bin/storage adjust`, for adjusting schemata (authored by epriestley, committed by epriestley).Oct 1 2014, 3:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementAdjustWorkflow.php

227 lines

Diff 25431

View Options

src/__phutil_library_map__.php