Page MenuHomePhabricator

Add missing expected keys and uniqueness
ClosedPublic

Authored by epriestley on Sep 27 2014, 10:56 PM.
Tags
None
Referenced Files
F14352029: D10590.diff
Thu, Dec 19, 12:33 PM
Unknown Object (File)
Tue, Dec 17, 7:04 AM
Unknown Object (File)
Thu, Dec 12, 10:40 AM
Unknown Object (File)
Thu, Dec 12, 12:04 AM
Unknown Object (File)
Mon, Dec 9, 8:56 AM
Unknown Object (File)
Sun, Dec 8, 7:51 PM
Unknown Object (File)
Sun, Dec 8, 3:14 PM
Unknown Object (File)
Sat, Dec 7, 5:00 AM
Subscribers

Details

Summary

Ref T1191.

  • Adds definitions for missing keys and keys with wrong uniqueness. Generally, I defined these before fixing the key query to actually pull all keys and support uniqueness.
  • Moves "key uniqueness" to note severity; this is fixable (probably?) and there are no remaining issues.
  • Moves "Missing Key" to note severity; missing keys are fixable and all remaining missing keys are really missing (either missing edge keys, or missing PHID keys):

Screen_Shot_2014-09-27_at_3.04.42_PM.png (716×1 px, 131 KB)

  • Moves "Surplus Key" to note seveirty; surplus keys are fixable all remaining surplus keys are really surplus (duplicate key in Harbormaster, key on unused column in Worker):

Screen_Shot_2014-09-27_at_3.50.24_PM.png (68×1 px, 15 KB)

Test Plan
  • Vetted missing/surplus/unique messages.
  • 146 issues remaining.

Diff Detail

Repository
rP Phabricator
Branch
utfx16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2678
Build 2682: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Add missing expected keys and uniqueness.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 4:50 PM
This revision was automatically updated to reflect the committed changes.