Page MenuHomePhabricator

Generate expected schemata for User/People tables
ClosedPublic

Authored by epriestley on Sep 26 2014, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 11:30 PM
Unknown Object (File)
Fri, Feb 7, 11:30 PM
Unknown Object (File)
Fri, Feb 7, 11:30 PM
Unknown Object (File)
Fri, Feb 7, 11:30 PM
Unknown Object (File)
Thu, Jan 30, 9:50 AM
Unknown Object (File)
Thu, Jan 23, 5:01 PM
Unknown Object (File)
Thu, Jan 23, 5:01 PM
Unknown Object (File)
Thu, Jan 23, 5:01 PM
Subscribers

Details

Summary

Ref T1191. Some notes here:

  • Drops the old LDAP and OAuth info tables. These were migrated to the ExternalAccount table a very long time ago.
  • Separates surplus/missing keys from other types of surplus/missing things. In the long run, my plan is to have only two notice levels:
    • Error: something we can't fix (missing database, table, or column; overlong key).
    • Warning: something we can fix (surplus anything, missing key, bad column type, bad key columns, bad uniqueness, bad collation or charset).
    • For now, retaining three levels is helpful in generating all the expected scheamta.
Test Plan
  • Saw ~200 issues resolve, leaving ~1,300.
  • Grepped for removed tables.

Diff Detail

Repository
rP Phabricator
Branch
utfx9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2665
Build 2669: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Generate expected schemata for User/People tables.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Give patches an umambiguous apply order.
This revision is now accepted and ready to land.Sep 30 2014, 4:44 PM
This revision was automatically updated to reflect the committed changes.