Paths

Table of Contentst

Differential D10569

Fix `LINT_ARRAY_SEPARATOR` for heredocs
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2014, 10:33 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC247a4fabb8b6: Fix `LINT_ARRAY_SEPARATOR` for heredocs

Summary

It is not correct to add a trailing comma if the n_ARRAY_VALUE node is a heredoc string.

Test Plan

Added a test case.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2652
Build 2656: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25388.Sep 25 2014, 10:33 PM

joshuaspence retitled this revision from to Fix `LINT_ARRAY_SEPARATOR` for heredocs.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 25 2014, 10:33 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Sep 25 2014, 10:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 25 2014, 10:33 PM

Harbormaster completed remote builds in B2652: Diff 25388.Sep 25 2014, 10:33 PM

Closed by commit rARC247a4fabb8b6: Fix `LINT_ARRAY_SEPARATOR` for heredocs (authored by joshuaspence, committed by joshuaspence).Sep 25 2014, 10:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

4 lines

__tests__/

xhpast/

array-comma.lint-test

10 lines

Diff 25388

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/array-comma.lint-test

Fix `LINT_ARRAY_SEPARATOR` for heredocsClosedPublicActions