Paths

Table of Contentst

Fix incorrect linter code being raised
ClosedPublic
Actions

Authored by joshuaspence on Sep 24 2014, 10:19 PM.

Tags

None

Referenced Files

	F14117516: D10553.id.diff
	Thu, Nov 28, 7:04 PM

	F14117515: D10553.id25354.diff
	Thu, Nov 28, 7:04 PM

	F14117514: D10553.id25365.diff
	Thu, Nov 28, 7:04 PM

	F14117450: D10553.diff
	Thu, Nov 28, 6:47 PM

	Unknown Object (File)
	Wed, Nov 27, 9:42 AM

	Unknown Object (File)
	Tue, Nov 26, 7:10 AM

	Unknown Object (File)
	Sun, Nov 17, 1:39 PM

	Unknown Object (File)
	Sun, Nov 17, 5:07 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCe6e317db27ce: Fix incorrect linter code being raised

Summary

ArcanistXHPASTLinter::lintSpaceAroundConcatenationOperators should raise LINT_CONCATENATION_OPERATOR, not LINT_BINARY_EXPRESSION_SPACING.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 25354.Sep 24 2014, 10:19 PM

joshuaspence retitled this revision from to Fix incorrect linter code being raised.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 24 2014, 10:19 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2629: Diff 25354.Sep 24 2014, 10:20 PM

epriestley accepted this revision.Sep 24 2014, 11:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 24 2014, 11:35 PM

Closed by commit rARCe6e317db27ce: Fix incorrect linter code being raised (authored by joshuaspence, committed by joshuaspence).Sep 25 2014, 2:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

2 lines

Diff 25365

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Fix incorrect linter code being raisedClosedPublicActions