Page MenuHomePhabricator
Differential D10553

Fix incorrect linter code being raised
ClosedPublic
Actions

Authored by joshuaspence on Sep 24 2014, 10:19 PM.
Tags
None
Referenced Files
F18874950: D10553.diff
Nov 5 2025, 4:22 PM
F18868098: D10553.id25365.diff
Nov 4 2025, 4:37 AM
F18857114: D10553.id25354.diff
Nov 1 2025, 1:19 PM
F18821918: D10553.diff
Oct 23 2025, 2:47 AM
F18630397: D10553.id25365.diff
Sep 16 2025, 11:34 AM
F18630391: D10553.id25365.diff
Sep 16 2025, 11:33 AM
F18209386: D10553.id25354.diff
Aug 18 2025, 10:43 PM
F18087914: D10553.diff
Aug 6 2025, 6:08 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCe6e317db27ce: Fix incorrect linter code being raised
Summary

ArcanistXHPASTLinter::lintSpaceAroundConcatenationOperators should raise LINT_CONCATENATION_OPERATOR, not LINT_BINARY_EXPRESSION_SPACING.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2629
Build 2633: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25354.Sep 24 2014, 10:19 PM
joshuaspence retitled this revision from to Fix incorrect linter code being raised.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 24 2014, 10:19 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2629: Diff 25354.Sep 24 2014, 10:20 PM
epriestley accepted this revision.Sep 24 2014, 11:35 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 24 2014, 11:35 PM
Closed by commit rARCe6e317db27ce: Fix incorrect linter code being raised (authored by joshuaspence, committed by joshuaspence).Sep 25 2014, 2:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
2 lines

Diff 25354

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility