Page MenuHomePhabricator
Differential D10536

`pht`ize some strings
ClosedPublic
Actions

Authored by joshuaspence on Sep 22 2014, 1:05 PM.
Tags
None
Referenced Files
F14036698: D10536.id25347.diff
Sun, Nov 10, 11:40 AM
F14036390: D10536.diff
Sun, Nov 10, 10:04 AM
F14034027: D10536.diff
Sat, Nov 9, 9:40 PM
F13990666: D10536.id25316.diff
Tue, Oct 22, 5:21 AM
F13989759: D10536.id25316.diff
Mon, Oct 21, 10:52 PM
F13981483: D10536.id25347.diff
Sat, Oct 19, 4:51 PM
F13981444: D10536.id25347.diff
Sat, Oct 19, 4:35 PM
F13981439: D10536.id.diff
Sat, Oct 19, 4:32 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC5951ec26b447: `pht`ize some strings
Summary

Self explanatory.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2625
Build 2629: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25316.Sep 22 2014, 1:05 PM
joshuaspence retitled this revision from to `pht`ize some strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 22 2014, 1:05 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2605: Diff 25316.Sep 22 2014, 1:06 PM
epriestley accepted this revision.Sep 24 2014, 9:00 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistTextLinter.php
163

Prefer new PhutilNumber() (more modern) instead of number_format() (older, obsolete).

This revision is now accepted and ready to land.Sep 24 2014, 9:00 PM
joshuaspence updated this revision to Diff 25346.Sep 24 2014, 9:11 PM
joshuaspence edited edge metadata.

Use PhutilNumber instead of number_format

Closed by commit rARC5951ec26b447: `pht`ize some strings (authored by joshuaspence, committed by joshuaspence).Sep 24 2014, 9:11 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B2625: Diff 25346.Sep 24 2014, 9:12 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
42 lines

Diff 25346

View Options

src/lint/linter/ArcanistTextLinter.php

Loading...
Phabricator · Built by Phacility