Page MenuHomePhabricator
Differential D10543

Shift footer when on page with sidenav
ClosedPublic
Actions

Authored by chad on Sep 23 2014, 7:34 PM.
Tags
None
Referenced Files
F13977202: D10543.diff
Fri, Oct 18, 5:36 PM
F13962640: D10543.id25335.diff
Tue, Oct 15, 11:22 AM
Unknown Object (File)
Sep 19 2024, 11:34 AM
Unknown Object (File)
Sep 19 2024, 11:34 AM
Unknown Object (File)
Sep 19 2024, 11:30 AM
Unknown Object (File)
Sep 19 2024, 8:24 AM
Unknown Object (File)
Sep 10 2024, 1:49 AM
Unknown Object (File)
Sep 7 2024, 4:19 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T6168: Long footer is partially hidden by left column in the homepage
Commits
Restricted Diffusion Commit
rP8ebe9cea92d6: Shift footer when on page with sidenav
Summary

Fixes T6168, adds spacing when navigation is present.

Test Plan

Tested Chrome, IE 9, 10. Numerous pages.

Diff Detail

Repository
rP Phabricator
Branch
footer-css
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2615
Build 2619: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25328.Sep 23 2014, 7:34 PM
chad retitled this revision from to Shift footer when on page with sidenav.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T6168: Long footer is partially hidden by left column in the homepage.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptSep 23 2014, 7:34 PM
Harbormaster completed remote builds in B2615: Diff 25328.Sep 23 2014, 7:34 PM
btrahan accepted this revision.Sep 24 2014, 2:53 PM
btrahan edited edge metadata.

whatcouldgowrong

This revision is now accepted and ready to land.Sep 24 2014, 2:53 PM
Closed by commit rP8ebe9cea92d6: Shift footer when on page with sidenav (authored by chad, committed by chad).Sep 24 2014, 4:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
page/
3 lines
webroot/
rsrc/
css/
application/
base/
8 lines

Diff 25328

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
Phabricator · Built by Phacility