If you have a very long footer, it will be eventually hidden by the left column in the homepage. See https://phabricator.wikimedia.org/.
It renders well in task pages i.e. https://phabricator.wikimedia.org/T171
Description
Description
Revisions and Commits
Revisions and Commits
| rP Phabricator | |||
| D10543 | rP8ebe9cea92d6 Shift footer when on page with sidenav | ||
Related Objects
Related Objects
Event Timeline
Comment Actions
Ugly, but as I spot
.phabricator-nav-column-background {
width: 204px; }for the sidebar, one could set
.phabricator-standard-page-footer {
padding: 8px 0px 8px 205px; }maybe?
Comment Actions
This was known when we added the option, our assumption being people would work around the issue.
Comment Actions
@aklapper that will solve one bad page, but there will be others (Differential File Tree?). If people are already hitting issue with the footer, we might want to just remove the feature quickly until we have bandwidth to properly test/support all use cases.
Comment Actions
@aklapper that will solve one bad page, but there will be others (Differential File Tree?). If people are already hitting issue with the footer, we might want to just remove the feature quickly until we have bandwidth to properly test/support all use cases.
Comment Actions
I'd rather have a defective footer in 1 homepage that looks correct in 1000s of tasks than no footer at all. Anytime. Please don't remove it.
Comment Actions
Need to test a few more devices, browsers, but go ahead and try this locally if you can:
diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php index bcf2748..9af3aff 100644 --- a/src/view/page/PhabricatorStandardPageView.php +++ b/src/view/page/PhabricatorStandardPageView.php @@ -352,7 +352,6 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { phutil_tag_div('phabricator-standard-page-body', array( ($console ? hsprintf('<darkconsole />') : null), parent::getBody(), - phutil_tag('div', array('style' => 'clear: both;')), $this->renderFooter(), )), )); @@ -508,7 +507,7 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { return phutil_tag( 'div', array( - 'class' => 'phabricator-standard-page-footer', + 'class' => 'phabricator-standard-page-footer grouped', ), $foot); } diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css index 301137c..afaf32e 100644 --- a/webroot/rsrc/css/application/base/standard-page-view.css +++ b/webroot/rsrc/css/application/base/standard-page-view.css @@ -21,6 +21,10 @@ color: {$lightgreytext}; } +.has-local-nav + .phabricator-standard-page-footer { + margin-left: 221px; +} + .keyboard-shortcut-help td, .keyboard-shortcut-help th { padding: 8px;