Paths

Table of Contentst

Differential D10536

`pht`ize some strings
ClosedPublic
Actions

Authored by joshuaspence on Sep 22 2014, 1:05 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC5951ec26b447: `pht`ize some strings

Summary

Self explanatory.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2605
Build 2609: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25316.Sep 22 2014, 1:05 PM

joshuaspence retitled this revision from to `pht`ize some strings.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 22 2014, 1:05 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2605: Diff 25316.Sep 22 2014, 1:06 PM

epriestley accepted this revision.Sep 24 2014, 9:00 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/lint/linter/ArcanistTextLinter.php
163	Prefer `new PhutilNumber()` (more modern) instead of `number_format()` (older, obsolete).

This revision is now accepted and ready to land.Sep 24 2014, 9:00 PM

Use PhutilNumber instead of number_format

Closed by commit rARC5951ec26b447: `pht`ize some strings (authored by joshuaspence, committed by joshuaspence).Sep 24 2014, 9:11 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B2625: Diff 25346.Sep 24 2014, 9:12 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistTextLinter.php

42 lines

Diff 25316

View Options

src/lint/linter/ArcanistTextLinter.php

`pht`ize some stringsClosedPublicActions