Differential D10476

Mark some methods in `ArcanistLinter` as final
ClosedPublic
Actions

Authored by joshuaspence on Sep 11 2014, 1:01 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCa0cb484db485: Mark some methods in `ArcanistLinter` as final

Summary

Minor change, self-explanatory... this seems to make sense.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/lint/linter/ArcanistLinter.php:77	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 2513
Build 2517: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25189.Sep 11 2014, 1:01 PM

joshuaspence retitled this revision from to Mark some methods in `ArcanistLinter` as final.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 11 2014, 1:01 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2513: Diff 25189.Sep 11 2014, 1:02 PM

epriestley accepted this revision.Oct 3 2014, 11:06 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 3 2014, 11:06 AM

Closed by commit rARCa0cb484db485: Mark some methods in `ArcanistLinter` as final (authored by joshuaspence, committed by joshuaspence).Oct 7 2014, 9:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistLinter.php

5 lines

Diff 25189

View Options

src/lint/linter/ArcanistLinter.php

Mark some methods in `ArcanistLinter` as finalClosedPublicActions