Page MenuHomePhabricator

Fix PHP version check for function calls with static/variable functions
ClosedPublic

Authored by epriestley on Sep 10 2014, 8:19 PM.
Tags
None
Referenced Files
F15410277: D10467.id25170.diff
Wed, Mar 19, 6:59 AM
F15369924: D10467.id25171.diff
Wed, Mar 12, 8:42 AM
Unknown Object (File)
Feb 6 2025, 8:04 PM
Unknown Object (File)
Jan 23 2025, 7:29 PM
Unknown Object (File)
Jan 17 2025, 4:59 PM
Unknown Object (File)
Nov 28 2024, 8:29 PM
Unknown Object (File)
Nov 28 2024, 8:29 PM
Unknown Object (File)
Nov 28 2024, 8:29 PM
Subscribers

Details

Summary

D10132 improved this check by eliminating some false postives, but assumes an n_FUNCTION_CALL always starts with n_SYMBOL_NAME. This is true for f(), but not true for C::m() or $v().

Test Plan

Added and ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
fcall
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2496
Build 2500: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix PHP version check for function calls with static/variable functions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
This revision is now accepted and ready to land.Sep 10 2014, 8:53 PM
epriestley updated this revision to Diff 25171.

Closed by commit rARCe043d22afd26 (authored by @epriestley).