Paths

Table of Contentst

Differential D10448

Minor fix for JSONLint
ClosedPublic
Actions

Authored by joshuaspence on Sep 9 2014, 1:40 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU1a59ecfe122a: Minor fix for JSONLint

Summary

In D10435, the JSONLint external was patched in an attempt to ensure PHP 5.2 compatibility. The fact that $this->lexer->lex() will produce a different token if invoked a second time was overlooked.

Test Plan

Ran ./bin/arc lint -- src/lint/linter in rARC.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 2472
Build 2476: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25131.Sep 9 2014, 1:40 PM

joshuaspence retitled this revision from to Minor fix for JSONLint.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 9 2014, 1:40 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2472: Diff 25131.Sep 9 2014, 1:41 PM

epriestley accepted this revision.Sep 9 2014, 2:02 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 9 2014, 2:02 PM

Closed by commit rPHU1a59ecfe122a (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

externals/

jsonlint/

src/

Seld/

JsonLint/

JsonParser.php

5 lines

Diff 25131

View Options

externals/jsonlint/src/Seld/JsonLint/JsonParser.php

Minor fix for JSONLintClosedPublicActions