Page MenuHomePhabricator

Phriction - fix edits with subscribers
ClosedPublic

Authored by btrahan on Sep 5 2014, 5:32 PM.
Tags
None
Referenced Files
F15488550: D10426.diff
Thu, Apr 10, 11:26 PM
F15486505: D10426.diff
Thu, Apr 10, 7:52 AM
F15484462: D10426.diff
Wed, Apr 9, 6:21 PM
F15478375: D10426.id25080.diff
Mon, Apr 7, 10:26 PM
F15468497: D10426.id25080.diff
Fri, Apr 4, 1:06 AM
F15461062: D10426.id.diff
Tue, Apr 1, 4:53 AM
F15424225: D10426.id.diff
Sat, Mar 22, 8:59 PM
F15395985: D10426.id25079.diff
Sun, Mar 16, 11:03 AM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPb51ae8f32d9d: Phriction - fix edits with subscribers
Summary

pre-patch, these fatal, since we overwrite $content to be just a string so methods fail later in the code. Instead, write a $content_str to keep $content as the proper data.

Test Plan

editing a document and on save it showed me the view page! (as opposed to fataling and staying on the eidt page)

Diff Detail

Repository
rP Phabricator
Branch
buggy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2444
Build 2448: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Phriction - fix edits with subscribers.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2014, 5:37 PM
btrahan updated this revision to Diff 25080.

Closed by commit rPb51ae8f32d9d (authored by @btrahan).