Page MenuHomePhabricator

Phriction - fix edits with subscribers
ClosedPublic

Authored by btrahan on Sep 5 2014, 5:32 PM.
Tags
None
Referenced Files
F18283650: D10426.id25080.diff
Sat, Aug 23, 1:43 AM
F18280924: D10426.id25079.diff
Fri, Aug 22, 10:26 PM
F18229304: D10426.id.diff
Wed, Aug 20, 10:10 AM
F18222910: D10426.diff
Tue, Aug 19, 9:54 PM
F18220873: D10426.diff
Tue, Aug 19, 4:18 PM
F17677318: D10426.id25080.diff
Jul 13 2025, 11:20 AM
F17667105: D10426.diff
Jul 12 2025, 10:05 PM
Unknown Object (File)
Jun 18 2025, 10:10 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPb51ae8f32d9d: Phriction - fix edits with subscribers
Summary

pre-patch, these fatal, since we overwrite $content to be just a string so methods fail later in the code. Instead, write a $content_str to keep $content as the proper data.

Test Plan

editing a document and on save it showed me the view page! (as opposed to fataling and staying on the eidt page)

Diff Detail

Repository
rP Phabricator
Branch
buggy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2444
Build 2448: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Phriction - fix edits with subscribers.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2014, 5:37 PM
btrahan updated this revision to Diff 25080.

Closed by commit rPb51ae8f32d9d (authored by @btrahan).