Page MenuHomePhabricator
Differential D10416

When users scroll while dragging items, update item positions immediately
ClosedPublic
Actions

Authored by epriestley on Sep 4 2014, 6:13 PM.
Tags
None
Referenced Files
F14826012: D10416.diff
Tue, Jan 28, 11:47 PM
Unknown Object (File)
Tue, Jan 28, 10:56 AM
Unknown Object (File)
Mon, Jan 27, 5:11 AM
Unknown Object (File)
Sat, Jan 25, 3:51 AM
Unknown Object (File)
Thu, Jan 23, 4:15 PM
Unknown Object (File)
Thu, Jan 23, 4:15 PM
Unknown Object (File)
Thu, Jan 23, 4:15 PM
Unknown Object (File)
Thu, Jan 23, 4:14 PM
View All Files
Subscribers
epriestley
Tokens
"Haypence" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T5979: Board drop target position is computed incorrectly after scrolling
Commits
Restricted Diffusion Commit
rPaaa08edb1251: When users scroll while dragging items, update item positions immediately
Summary

Fixes T5979. When you drag a task and scroll using the mouse wheel, we don't move the task under your cursor until you move the mouse.

Instead, listen for scroll and move the task.

Test Plan
  • Clicked and dragged a task.
  • While holding the task and not moving the cursor, used the mouse wheel to scroll.
  • The task followed the cursor (previously, it stayed in position until the mouse was moved again).

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 25060.Sep 4 2014, 6:13 PM
epriestley retitled this revision from to When users scroll while dragging items, update item positions immediately.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5979: Board drop target position is computed incorrectly after scrolling.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 4 2014, 6:13 PM
Harbormaster completed remote builds in B2434: Diff 25060.Sep 4 2014, 6:13 PM
btrahan accepted this revision.Sep 4 2014, 7:35 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2014, 7:35 PM
btrahan awarded a token.Sep 4 2014, 7:36 PM
epriestley closed this revision.Sep 4 2014, 7:47 PM
epriestley updated this revision to Diff 25063.

Closed by commit rPaaa08edb1251 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
webroot/
rsrc/
js/
core/
17 lines

Diff 25063

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/DraggableList.js

Loading...
Phabricator · Built by Phacility