Page MenuHomePhabricator
Differential D10409

[drydock/core] Mark leases as broken when failing to acquiring lease
AbandonedPublic
Actions

Authored by epriestley on Sep 4 2014, 7:56 AM.
Tags
None
Referenced Files
F14818235: D10409.id.diff
Tue, Jan 28, 2:38 AM
Unknown Object (File)
Mon, Jan 27, 10:05 AM
Unknown Object (File)
Thu, Jan 23, 4:12 PM
Unknown Object (File)
Thu, Jan 23, 4:12 PM
Unknown Object (File)
Thu, Jan 23, 4:12 PM
Unknown Object (File)
Thu, Jan 23, 4:12 PM
Unknown Object (File)
Thu, Jan 23, 4:12 PM
Unknown Object (File)
Tue, Jan 21, 7:24 PM
View All Files
Subscribers
epriestley
joshuaspence
Korvin

Details

Reviewers
hach-que
Group Reviewers
Blessed Reviewers
Summary

This ensures Drydock leases get marked as Broken when acquiring the lease fails, so that resources don't stay open despite haven't no actual leases against them.

Test Plan

Tested in production

Diff Detail

Repository
rP Phabricator
Branch
drydock-mark-lease-as-broken
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2424
Build 2428: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25049.Sep 4 2014, 7:56 AM
hach-que retitled this revision from to Mark leases as broken when failing to acquiring lease.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 4 2014, 7:56 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2424: Diff 25049.Sep 4 2014, 7:56 AM
hach-que updated this revision to Diff 25050.Sep 4 2014, 8:03 AM
hach-que edited edge metadata.

Also ensure resources are closed if the only active lease was the one that was broken

Harbormaster completed remote builds in B2425: Diff 25050.Sep 4 2014, 8:04 AM
joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 5:46 AM
epriestley requested changes to this revision.Aug 8 2015, 5:49 PM
epriestley edited edge metadata.

Haven't tested this yet

This revision now requires changes to proceed.Aug 8 2015, 5:49 PM
hach-que requested a review of this revision.Aug 24 2015, 2:41 AM
hach-que edited the test plan for this revision. (Show Details)
hach-que edited edge metadata.
hach-que retitled this revision from Mark leases as broken when failing to acquiring lease to [drydock/core] Mark leases as broken when failing to acquiring lease.
hach-que edited edge metadata.

This patch has actually been in production for 6+ months.

hach-que updated this revision to Diff 33739.Aug 24 2015, 2:51 AM
hach-que edited edge metadata.

Rebase

hach-que mentioned this in D10304: [drydock/core] Implement resource constraints and correct locking mechanisms with yielding for Drydock.Aug 24 2015, 7:48 PM
epriestley commandeered this revision.Oct 1 2015, 2:35 PM
epriestley edited reviewers, added: hach-que; removed: epriestley.

This should be handled by D14212 (and companion D14211, for resources) now. They're probably still a bit shaky but basically do the exact same thing this patch does.

epriestley abandoned this revision.Oct 1 2015, 2:35 PM

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
blueprint/
4 lines

Diff 25049

View Options

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

Loading...
Phabricator · Built by Phacility