Ref T3307. Only one I thought was tricky was Excel; I went with bytes there like it was email.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T3307: Create `phutil_utf8_truncate()` or make `phutil_utf8_shorten()` more sophisticated
- Commits
- Restricted Diffusion Commit
rPb93bc7e47947: phutil_utf8_shorten => PhutilUTF8StringTruncator
played around on a few endpoints but mostly thought carefully
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T3307
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 2396 Build 2400: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Cool, these look good to me. I think bytes is reasonable for Excel.
| src/applications/herald/storage/transcript/HeraldObjectTranscript.php | ||
|---|---|---|
| 55 | Missing "PhutilUTF8StringTruncator has"? | |