Page MenuHomePhabricator
Differential D10392

phutil_utf8_shorten => PhutilUTF8StringTruncator
ClosedPublic
Actions

Authored by btrahan on Aug 29 2014, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 11:14 AM
Unknown Object (File)
Fri, Dec 6, 5:25 PM
Unknown Object (File)
Fri, Dec 6, 3:39 PM
Unknown Object (File)
Wed, Dec 4, 2:50 PM
Unknown Object (File)
Wed, Dec 4, 2:23 PM
Unknown Object (File)
Wed, Dec 4, 4:22 AM
Unknown Object (File)
Sun, Dec 1, 8:50 AM
Unknown Object (File)
Thu, Nov 28, 4:40 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3307: Create `phutil_utf8_truncate()` or make `phutil_utf8_shorten()` more sophisticated
Commits
Restricted Diffusion Commit
rPb93bc7e47947: phutil_utf8_shorten => PhutilUTF8StringTruncator
Summary

Ref T3307. Only one I thought was tricky was Excel; I went with bytes there like it was email.

Test Plan

played around on a few endpoints but mostly thought carefully

Diff Detail

Repository
rP Phabricator
Branch
T3307
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2396
Build 2400: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25008.Aug 29 2014, 9:34 PM
btrahan added a task: T3307: Create `phutil_utf8_truncate()` or make `phutil_utf8_shorten()` more sophisticated.
btrahan retitled this revision from to phutil_utf8_shorten => PhutilUTF8StringTruncator.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 29 2014, 9:34 PM
Harbormaster completed remote builds in B2396: Diff 25008.Aug 29 2014, 9:35 PM
epriestley accepted this revision.Aug 29 2014, 9:58 PM
epriestley edited edge metadata.

Cool, these look good to me. I think bytes is reasonable for Excel.

src/applications/herald/storage/transcript/HeraldObjectTranscript.php
55

Missing "PhutilUTF8StringTruncator has"?

This revision is now accepted and ready to land.Aug 29 2014, 9:58 PM
btrahan closed this revision.Aug 29 2014, 10:11 PM
btrahan updated this revision to Diff 25011.

Closed by commit rPb93bc7e47947 (authored by @btrahan).

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
5 lines
chatlog/
controller/
4 lines
conduit/
method/
6 lines
conpherence/
view/
4 lines
differential/
controller/
6 lines
event/
4 lines
parser/
6 lines
view/
4 lines
diffusion/
controller/
5 lines
feed/
story/
4 lines
harbormaster/
storage/
build/
4 lines
herald/
storage/
transcript/
2 lines
maniphest/
export/
4 lines
metamta/
storage/
4 lines
people/
event/
4 lines
phame/
conduit/
4 lines
pholio/
storage/
4 lines
phriction/
editor/
5 lines
ponder/
storage/
4 lines
8 lines
repository/
storage/
4 lines
slowvote/
query/
4 lines
view/
form/
control/
5 lines

Diff 25008

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

Loading...
View Options

src/applications/conduit/method/ConduitConnectConduitAPIMethod.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceFileWidgetView.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/event/DifferentialHovercardEventListener.php

Loading...
View Options

src/applications/differential/parser/DifferentialCommitMessageParser.php

Loading...
View Options

src/applications/differential/view/DifferentialLocalCommitsView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStory.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldObjectTranscript.php

Loading...
View Options

src/applications/maniphest/export/ManiphestExcelDefaultFormat.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...
View Options

src/applications/people/event/PhabricatorPeopleHovercardEventListener.php

Loading...
View Options

src/applications/phame/conduit/PhameCreatePostConduitAPIMethod.php

Loading...
View Options

src/applications/pholio/storage/PholioTransaction.php

Loading...
View Options

src/applications/phriction/editor/PhrictionDocumentEditor.php

Loading...
View Options

src/applications/ponder/storage/PonderAnswerTransaction.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestionTransaction.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommitData.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
Phabricator · Built by Phacility