Paths

Table of Contentst

Differential D10374

Add a failing test case for the XHProf PHP 5.5 segfault
ClosedPublic
Actions

Authored by epriestley on Aug 27 2014, 10:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 6:30 AM

	Unknown Object (File)
	Fri, Nov 15, 6:31 AM

	Unknown Object (File)
	Tue, Nov 12, 10:56 PM

	Unknown Object (File)
	Mon, Nov 11, 11:25 AM

	Unknown Object (File)
	Thu, Nov 7, 7:12 AM

	Unknown Object (File)
	Tue, Nov 5, 11:16 AM

	Unknown Object (File)
	Oct 18 2024, 12:36 PM

	Unknown Object (File)
	Oct 17 2024, 11:38 AM

Subscribers

Details

Reviewers

Commits

rXPRFd8ca30af371e: Add a failing test case for the XHProf PHP 5.5 segfault

Summary

This adds a failing test case for the bug discussed in https://github.com/phacility/xhprof/pull/33.

It also adds a bin/xhprofile script which makes it easier to test stuff like this, by invoking the profiler on some other script. This isn't hugely useful in production but is valuable diagnostically, and helped me reduce this test case.

Test Plan

Ran arc unit and got a failure.
Verified that this test passes if class_exists() is commented out (which makes the test not segfault).

Diff Detail

Repository

Branch

arclint3

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 2376
Build 2380: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	XHPRrof: PHP 5.5 crash in hp_execute_internal
	0 ms	XHPRrof: Test Include File (load/run_init operations)
	0 ms	XHPRrof: Test excluding call_user_func and similar functions
	0 ms	XHPRrof: Basic Profiling Test
	0 ms	XHPRrof: Basic Sampling Test
		View Full Test Results (3 Failed · 6 Passed)

Event Timeline

epriestley updated this revision to Diff 24970.Aug 27 2014, 10:51 PM

epriestley retitled this revision from to Add a failing test case for the XHProf PHP 5.5 segfault.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 27 2014, 10:51 PM

Harbormaster completed remote builds in B2376: Diff 24970.Aug 27 2014, 10:52 PM

btrahan accepted this revision.Aug 28 2014, 5:23 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 28 2014, 5:23 PM

Closed by commit rXPRFd8ca30af371e (authored by @epriestley).

epriestley mentioned this in T9805: XHProf will not build on PHP7.Nov 29 2017, 8:57 PM

Revision Contents
Changeset List

Path

Size

bin/

1 line

extension/

tests/

xhprof_009.phpt

19 lines

scripts/

19 lines

Diff 24970

bin/xhprofile

Loading...

extension/tests/xhprof_009.phpt

Loading...

scripts/xhprofile.php

Loading...