Page MenuHomePhabricator

Add a failing test case for the XHProf PHP 5.5 segfault
ClosedPublic

Authored by epriestley on Aug 27 2014, 10:51 PM.

Details

Summary

This adds a failing test case for the bug discussed in https://github.com/phacility/xhprof/pull/33.

It also adds a bin/xhprofile script which makes it easier to test stuff like this, by invoking the profiler on some other script. This isn't hugely useful in production but is valuable diagnostically, and helped me reduce this test case.

Test Plan
  • Ran arc unit and got a failure.
  • Verified that this test passes if class_exists() is commented out (which makes the test not segfault).

Diff Detail

Repository
rXPRF XHProf
Branch
arclint3
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 2376
Build 2380: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 msXHPRrof: PHP 5.5 crash in hp_execute_internal
0 msXHPRrof: Test Include File (load/run_init operations)
0 msXHPRrof: Test excluding call_user_func and similar functions
0 msXHPRrof: Basic Profiling Test
0 msXHPRrof: Basic Sampling Test
View Full Test Results (3 Failed · 6 Passed)

Event Timeline

epriestley retitled this revision from to Add a failing test case for the XHProf PHP 5.5 segfault.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 28 2014, 5:23 PM
epriestley updated this revision to Diff 24983.

Closed by commit rXPRFd8ca30af371e (authored by @epriestley).