Page MenuHomePhabricator
Differential D10369

Notifications - fix pager
ClosedPublic
Actions

Authored by btrahan on Aug 27 2014, 7:14 PM.
Tags
None
Referenced Files
F15551124: D10369.id24956.diff
Sun, Apr 27, 3:23 PM
F15539225: D10369.id24958.diff
Fri, Apr 25, 12:13 AM
F15525191: D10369.diff
Mon, Apr 21, 12:45 PM
F15504026: D10369.id24956.diff
Mon, Apr 14, 3:14 PM
F15472979: D10369.diff
Apr 5 2025, 6:08 PM
F15450129: D10369.id24956.diff
Mar 28 2025, 2:10 PM
F15449169: D10369.id.diff
Mar 28 2025, 8:42 AM
F15448523: D10369.id24958.diff
Mar 28 2025, 5:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5975: Next button in notifications page doesn't work
Commits
Restricted Diffusion Commit
rP85b767bbdc65: Notifications - fix pager
Summary

D10281 upgraded us to modern infrastructure but I think forget to set this little helper to return true. Fixes T5975.

Test Plan

paged through notifications with glee

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2368
Build 2372: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24956.Aug 27 2014, 7:14 PM
btrahan retitled this revision from to Notifications - fix pager.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a task: T5975: Next button in notifications page doesn't work.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 27 2014, 7:14 PM
Harbormaster completed remote builds in B2368: Diff 24956.Aug 27 2014, 7:15 PM
epriestley accepted this revision.Aug 27 2014, 7:16 PM
epriestley edited edge metadata.

I think we could cursor page this on chronologicalKey but this is reasonable, at least until we have a better reason to support cursor paging.

This revision is now accepted and ready to land.Aug 27 2014, 7:16 PM
btrahan added a comment.Aug 27 2014, 7:19 PM

yeah, I tried to get that going actually and it was being all funky on me. :/

btrahan closed this revision.Aug 27 2014, 7:20 PM
btrahan updated this revision to Diff 24958.

Closed by commit rP85b767bbdc65 (authored by @btrahan).

Revision Contents
Changeset List

PathSize
src/
applications/
notification/
query/
4 lines

Diff 24956

View Options

src/applications/notification/query/PhabricatorNotificationSearchEngine.php

Loading...
Phabricator · Built by Phacility