Page MenuHomePhabricator
Differential D10353

Add a remarkup element for a navigation sequence
ClosedPublic
Actions

Authored by epriestley on Aug 26 2014, 7:03 PM.
Tags
None
Referenced Files
F13206488: D10353.id.diff
Wed, May 15, 11:04 AM
F13203645: D10353.diff
Tue, May 14, 11:57 PM
F13186126: D10353.diff
Sat, May 11, 3:26 AM
Unknown Object (File)
Tue, May 7, 6:13 AM
Unknown Object (File)
Fri, May 3, 3:53 AM
Unknown Object (File)
Mon, Apr 29, 3:59 PM
Unknown Object (File)
Wed, Apr 24, 11:51 PM
Unknown Object (File)
Mon, Apr 22, 8:05 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4769: Add a Remarkup element for a navigation sequence
Commits
Restricted Diffusion Commit
rP2d69e2bdee0e: Add a remarkup element for a navigation sequence
Summary

Fixes T4769. This is silly and just scratches an itch, but do a better job with navigation sequences.

Test Plan

Screen_Shot_2014-08-26_at_12.02.45_PM.png (421×994 px, 47 KB)

Diff Detail

Repository
rP Phabricator
Branch
navseq
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2350
Build 2354: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24922.Aug 26 2014, 7:03 PM
epriestley retitled this revision from to Add a remarkup element for a navigation sequence.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T4769: Add a Remarkup element for a navigation sequence.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 26 2014, 7:03 PM
Harbormaster completed remote builds in B2350: Diff 24922.Aug 26 2014, 7:04 PM
chad accepted this revision.Aug 26 2014, 7:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 26 2014, 7:10 PM
epriestley closed this revision.Aug 26 2014, 7:14 PM
epriestley updated this revision to Diff 24923.

Closed by commit rP2d69e2bdee0e (authored by @epriestley).

chad added a comment.Aug 26 2014, 7:21 PM

1000x500px-LL-b05a5df6_Borat-VeryNice.jpg (160×136 px, 15 KB)

Revision Contents
Changeset List

PathSize
src/
2 lines
docs/
user/
userguide/
31 lines
infrastructure/
markup/
1 line
rule/
103 lines
webroot/
rsrc/
css/
core/
4 lines

Diff 24922

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/docs/user/userguide/remarkup.diviner

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/rule/PhabricatorNavigationRemarkupRule.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility