Fix herald "Repository" rule for Revisions and Diffs
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 5:52 PM.

Details

Reviewers

btrahan
nickz
chad

Commits

Restricted Diffusion Commit
rPf50ba4fb070a: Fix herald "Repository" rule for Revisions and Diffs

Summary

This was broken by rP5ac36e8 by a derpy typo.

Test Plan

Ran dry run against a revision with a a repository, saw the field fill in on the transcript.

Diff Detail

Repository

rP Phabricator

Branch

reporule

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2316
Build 2320: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24856.Aug 21 2014, 5:52 PM

epriestley retitled this revision from to Fix herald "Repository" rule for Revisions and Commits.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: nickz, btrahan, chad.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 5:52 PM

epriestley retitled this revision from Fix herald "Repository" rule for Revisions and Commits to Fix herald "Repository" rule for Revisions and Diffs.Aug 21 2014, 5:52 PM

chad accepted this revision.Aug 21 2014, 5:53 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 21 2014, 5:53 PM

Harbormaster completed remote builds in B2316: Diff 24856.Aug 21 2014, 5:53 PM

Closed by commit rPf50ba4fb070a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldDifferentialAdapter.php

2 lines

Diff 24856

View Options

src/applications/herald/adapter/HeraldDifferentialAdapter.php

Fix herald "Repository" rule for Revisions and DiffsClosedPublicActions