Page MenuHomePhabricator
Differential D10315

Work around OSX after Yosemite no longer respecting CURLOPT_CAINFO
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 12:15 AM.
Tags
None
Referenced Files
F13139569: D10315.diff
Fri, May 3, 2:54 AM
F13135237: D10315.diff
Thu, May 2, 7:44 AM
Unknown Object (File)
Mon, Apr 29, 4:55 PM
Unknown Object (File)
Wed, Apr 24, 7:53 AM
Unknown Object (File)
Thu, Apr 11, 7:14 AM
Unknown Object (File)
Wed, Apr 10, 2:16 AM
Unknown Object (File)
Mar 31 2024, 5:13 AM
Unknown Object (File)
Feb 25 2024, 1:35 PM
View All Files
Subscribers
epriestley
ide
Tokens
"Doubloon" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T5913: SSL not working on OSX Yosemite Beta 6
Commits
rPHU44b37c30004b: Work around OSX after Yosemite no longer respecting CURLOPT_CAINFO
Summary

Fixes T5913. See discussion in that task.

Test Plan

Will make affected users in T5913 test.

Diff Detail

Repository
rPHU libphutil
Branch
yosemite
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/future/http/HTTPSFuture.php:549XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 2296
Build 2300: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24832.Aug 21 2014, 12:15 AM
epriestley retitled this revision from to Work around OSX after Yosemite no longer respecting CURLOPT_CAINFO.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5913: SSL not working on OSX Yosemite Beta 6.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 12:15 AM
Harbormaster completed remote builds in B2296: Diff 24832.Aug 21 2014, 12:16 AM
epriestley added a comment.Aug 21 2014, 12:25 AM

We have several confirmations in T5913 that this seems to work correctly.

ide added a subscriber: ide.Aug 21 2014, 12:28 AM

With this diff I can connect to secure.phabricator.com from arc so it looks to be in working order. commented on some typos i noticed.

src/future/http/HTTPSFuture.php
602

cannot

src/future/http/status/HTTPFutureCertificateResponseStatus.php
23

negotiating, connection

epriestley updated this revision to Diff 24833.Aug 21 2014, 12:31 AM
  • chack spalls
Harbormaster completed remote builds in B2297: Diff 24833.Aug 21 2014, 12:32 AM
btrahan accepted this revision.Aug 21 2014, 6:22 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 21 2014, 6:22 PM
btrahan awarded a token.Aug 21 2014, 6:22 PM
epriestley closed this revision.Aug 21 2014, 6:24 PM
epriestley updated this revision to Diff 24860.

Closed by commit rPHU44b37c30004b (authored by @epriestley).

jbinney mentioned this in T5913: SSL not working on OSX Yosemite Beta 6.Sep 11 2014, 7:05 PM

Revision Contents
Changeset List

PathSize
resources/
ssl/
20 lines
src/
3 lines
future/
http/
39 lines
status/
33 lines
utils/
16 lines

Diff 24832

View Options

resources/ssl/README

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/future/http/HTTPSFuture.php

Loading...
View Options

src/future/http/status/HTTPFutureCertificateResponseStatus.php

Loading...
View Options

src/utils/PhutilExecutionEnvironment.php

Loading...
Phabricator · Built by Phacility