Don't SIGINT ourselves on bad daemon data
ClosedPublic
Actions

Authored by epriestley on Aug 20 2014, 5:34 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP15385e1fe9b5: Don't SIGINT ourselves on bad daemon data

Summary

If daemon data is mangled, bin/phd restart will SIGINT process 0, which kills it.

uh oh T.T so sad

Test Plan

Used bin/phd start to start daemons; removed PID information from one; saw bin/phd stop shut down cleanly and not kill itself.

Diff Detail

Repository

rP Phabricator

Branch

sigint

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2289
Build 2293: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24817.Aug 20 2014, 5:34 PM

epriestley retitled this revision from to Don't SIGINT ourselves on bad daemon data.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 20 2014, 5:34 PM

Harbormaster completed remote builds in B2289: Diff 24817.Aug 20 2014, 5:35 PM

I complained about this issue and I approve this commit ;p

btrahan accepted this revision.Aug 20 2014, 8:02 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 20 2014, 8:02 PM

Closed by commit rP15385e1fe9b5 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

management/

PhabricatorDaemonManagementWorkflow.php

6 lines

Diff 24817

View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Don't SIGINT ourselves on bad daemon dataClosedPublicActions