Paths

Table of Contentst

Don't SIGINT ourselves on bad daemon data
ClosedPublic
Actions

Authored by epriestley on Aug 20 2014, 5:34 PM.

Tags

None

Referenced Files

	F13048644: D10308.diff
	Thu, Apr 18, 9:51 PM

	Unknown Object (File)
	Thu, Apr 11, 8:11 AM

	Unknown Object (File)
	Fri, Mar 29, 3:35 PM

	Unknown Object (File)
	Fri, Mar 29, 6:33 AM

	Unknown Object (File)
	Mar 14 2024, 12:45 AM

	Unknown Object (File)
	Mar 14 2024, 12:45 AM

	Unknown Object (File)
	Mar 14 2024, 12:43 AM

	Unknown Object (File)
	Mar 14 2024, 12:34 AM

View All Files

Subscribers

epriestley

• mholden

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP15385e1fe9b5: Don't SIGINT ourselves on bad daemon data

Summary

If daemon data is mangled, bin/phd restart will SIGINT process 0, which kills it.

uh oh T.T so sad

Test Plan

Used bin/phd start to start daemons; removed PID information from one; saw bin/phd stop shut down cleanly and not kill itself.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24817.Aug 20 2014, 5:34 PM

epriestley retitled this revision from to Don't SIGINT ourselves on bad daemon data.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 20 2014, 5:34 PM

Harbormaster completed remote builds in B2289: Diff 24817.Aug 20 2014, 5:35 PM

I complained about this issue and I approve this commit ;p

btrahan accepted this revision.Aug 20 2014, 8:02 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 20 2014, 8:02 PM

Closed by commit rP15385e1fe9b5 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

management/

PhabricatorDaemonManagementWorkflow.php

6 lines

Diff 24821

View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Don't SIGINT ourselves on bad daemon dataClosedPublicActions