Fix external redirect flagging issue with image thumbnails
ClosedPublic
Actions

Authored by epriestley on Aug 19 2014, 9:13 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5894: Thumbnails of uploaded files broken when not logged in

Commits

Restricted Diffusion Commit
rPe8c51cd934da: Fix external redirect flagging issue with image thumbnails

Summary

Fixes T5894. This needs some improvement when we lay in real CDN stuff, but should get all the cases right for now.

Test Plan

Thumbnails work properly again.

Diff Detail

Repository

rP Phabricator

Branch

xredirect

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/files/controller/PhabricatorFileTransformController.php:153	XHP16	TODO Comment

Unit

No Test Coverage

Build Status

Buildable 2277
Build 2281: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24796.Aug 19 2014, 9:13 PM

epriestley retitled this revision from to Fix external redirect flagging issue with image thumbnails.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T5894: Thumbnails of uploaded files broken when not logged in.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 19 2014, 9:13 PM

chad accepted this revision.Aug 19 2014, 9:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 19 2014, 9:14 PM

Harbormaster completed remote builds in B2277: Diff 24796.Aug 19 2014, 9:14 PM

Closed by commit rPe8c51cd934da (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileTransformController.php

16 lines

Diff 24796

View Options

src/applications/files/controller/PhabricatorFileTransformController.php

Fix external redirect flagging issue with image thumbnailsClosedPublicActions