Page MenuHomePhabricator
Differential D10299

Fix external redirect flagging issue with image thumbnails
ClosedPublic
Actions

Authored by epriestley on Aug 19 2014, 9:13 PM.
Tags
None
Referenced Files
F18831451: D10299.id.diff
Sat, Oct 25, 1:11 PM
F18826757: D10299.diff
Fri, Oct 24, 5:36 AM
F18824737: D10299.id24797.diff
Thu, Oct 23, 5:39 PM
F18755574: D10299.diff
Sun, Oct 5, 6:20 AM
F18712114: D10299.id.diff
Sep 29 2025, 5:16 AM
F18629319: D10299.id.diff
Sep 16 2025, 8:30 AM
F18629065: D10299.id24796.diff
Sep 16 2025, 7:55 AM
F18628289: D10299.id24796.diff
Sep 16 2025, 6:03 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5894: Thumbnails of uploaded files broken when not logged in
Commits
Restricted Diffusion Commit
rPe8c51cd934da: Fix external redirect flagging issue with image thumbnails
Summary

Fixes T5894. This needs some improvement when we lay in real CDN stuff, but should get all the cases right for now.

Test Plan

Thumbnails work properly again.

Diff Detail

Repository
rP Phabricator
Branch
xredirect
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/files/controller/PhabricatorFileTransformController.php:153XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 2277
Build 2281: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24796.Aug 19 2014, 9:13 PM
epriestley retitled this revision from to Fix external redirect flagging issue with image thumbnails.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T5894: Thumbnails of uploaded files broken when not logged in.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 19 2014, 9:13 PM
chad accepted this revision.Aug 19 2014, 9:14 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2014, 9:14 PM
Harbormaster completed remote builds in B2277: Diff 24796.Aug 19 2014, 9:14 PM
epriestley closed this revision.Aug 19 2014, 9:21 PM
epriestley updated this revision to Diff 24797.

Closed by commit rPe8c51cd934da (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
files/
controller/
16 lines

Diff 24796

View Options

src/applications/files/controller/PhabricatorFileTransformController.php

Loading...
Phabricator · Built by Phacility