Page MenuHomePhabricator
Differential D10296

Clean up image file diffs UI
ClosedPublic
Actions

Authored by chad on Aug 19 2014, 8:18 PM.
Tags
None
Referenced Files
F13202669: D10296.diff
Tue, May 14, 10:59 PM
F13185035: D10296.diff
Sat, May 11, 2:31 AM
Unknown Object (File)
Tue, May 7, 4:51 AM
Unknown Object (File)
Fri, May 3, 2:12 AM
Unknown Object (File)
Mon, Apr 29, 1:35 PM
Unknown Object (File)
Sun, Apr 28, 4:34 PM
Unknown Object (File)
Wed, Apr 24, 9:49 PM
Unknown Object (File)
Sun, Apr 21, 3:39 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T4910: Handle large image files in Differential better
T5874: Clean up file changes table
Commits
Restricted Diffusion Commit
rP0057cf17e9d0: Clean up image file diffs UI
Summary

Uses AphrontTable now, cleans up interactions. Fixes T5874, Fixes T4910

Test Plan

tested a large image

undefined (667×1 px, 331 KB)

Diff Detail

Repository
rP Phabricator
Branch
filediff
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2274
Build 2278: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 24792.Aug 19 2014, 8:18 PM
chad retitled this revision from to Clean up image file diffs UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added tasks: T5874: Clean up file changes table, T4910: Handle large image files in Differential better.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 19 2014, 8:18 PM
chad edited the test plan for this revision. (Show Details)Aug 19 2014, 8:19 PM
Harbormaster completed remote builds in B2273: Diff 24792.Aug 19 2014, 8:19 PM
chad updated this revision to Diff 24793.Aug 19 2014, 8:20 PM
  • derp
Harbormaster completed remote builds in B2274: Diff 24793.Aug 19 2014, 8:21 PM
epriestley accepted this revision.Aug 19 2014, 9:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2014, 9:45 PM
chad added a comment.Aug 19 2014, 9:46 PM

Also, @btrahan, which highchair should I go with. Leaning towards the one that looks like it came from Ork.

chad closed this revision.Aug 19 2014, 9:46 PM
chad updated this revision to Diff 24798.

Closed by commit rP0057cf17e9d0 (authored by @chad).

epriestley added a comment.Aug 19 2014, 9:48 PM

wow those baby chairs are super expensive

btrahan edited edge metadata.Aug 19 2014, 11:24 PM

...I have no idea what makes for a good high chair. :/

Revision Contents
Changeset List

PathSize
resources/
celerity/
26 lines
src/
applications/
differential/
render/
37 lines
webroot/
rsrc/
css/
application/
differential/
47 lines

Diff 24793

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility